fix: parse bool to string first

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
This commit is contained in:
Aaron Pham 2024-08-02 17:44:05 -04:00
parent 077e79c48f
commit a572e9336e
No known key found for this signature in database
GPG Key ID: 18974753009D2BFA
2 changed files with 10 additions and 9 deletions

View File

@ -17,6 +17,10 @@ type Options = {
} }
} }
function boolToStringBool(b: boolean): string {
return b ? "1" : "0"
}
export default ((opts: Options) => { export default ((opts: Options) => {
const Comments: QuartzComponent = ({ displayClass, cfg }: QuartzComponentProps) => { const Comments: QuartzComponent = ({ displayClass, cfg }: QuartzComponentProps) => {
return ( return (
@ -27,8 +31,8 @@ export default ((opts: Options) => {
data-category={opts.options.category} data-category={opts.options.category}
data-category-id={opts.options.categoryId} data-category-id={opts.options.categoryId}
data-mapping={opts.options.mapping ?? "url"} data-mapping={opts.options.mapping ?? "url"}
data-strict={opts.options.strict ?? true} data-strict={boolToStringBool(opts.options.strict ?? true)}
data-reactions-enabled={opts.options.reactionsEnabled ?? true} data-reactions-enabled={boolToStringBool(opts.options.reactionsEnabled ?? true)}
data-input-position={opts.options.inputPosition ?? "bottom"} data-input-position={opts.options.inputPosition ?? "bottom"}
></div> ></div>
) )

View File

@ -32,8 +32,8 @@ type GiscusElement = Omit<HTMLElement, "dataset"> & {
category: string category: string
categoryId: string categoryId: string
mapping: "url" | "title" | "og:title" | "specific" | "number" | "pathname" mapping: "url" | "title" | "og:title" | "specific" | "number" | "pathname"
strict: boolean strict: string
reactionsEnabled: boolean reactionsEnabled: string
inputPosition: "top" | "bottom" inputPosition: "top" | "bottom"
} }
} }
@ -55,11 +55,8 @@ document.addEventListener("nav", () => {
giscusScript.setAttribute("data-category", giscusContainer.dataset.category) giscusScript.setAttribute("data-category", giscusContainer.dataset.category)
giscusScript.setAttribute("data-category-id", giscusContainer.dataset.categoryId) giscusScript.setAttribute("data-category-id", giscusContainer.dataset.categoryId)
giscusScript.setAttribute("data-mapping", giscusContainer.dataset.mapping) giscusScript.setAttribute("data-mapping", giscusContainer.dataset.mapping)
giscusScript.setAttribute("data-strict", boolToStringBool(giscusContainer.dataset.strict)) giscusScript.setAttribute("data-strict", giscusContainer.dataset.strict)
giscusScript.setAttribute( giscusScript.setAttribute("data-reactions-enabled", giscusContainer.dataset.reactionsEnabled)
"data-reactions-enabled",
boolToStringBool(giscusContainer.dataset.reactionsEnabled),
)
giscusScript.setAttribute("data-input-position", giscusContainer.dataset.inputPosition) giscusScript.setAttribute("data-input-position", giscusContainer.dataset.inputPosition)
const theme = document.documentElement.getAttribute("saved-theme") const theme = document.documentElement.getAttribute("saved-theme")